Fix incorrect parsing #3214
Merged
Fix incorrect parsing #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneBeee
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tracked down this issue down to this section of
VariableString, where a plain text component is returned.I'm pretty sure this is safe to do, so it shouldn't cause any issues. I figured grabbing the hex, updating the color, and removing it from the text would be the most efficient way to do this (instead of calling
ChatMessages#parse).While
Utils#parseHexColormay return a nullChatColor, I don't think this code will ever run if the hex color is invalid, astextwon't contain§x.Target Minecraft Versions: 1.16+
Requirements: None
Related Issues: #3213